Replacement patch for 5.005_58
Nathan Torkington (gnat@frii.com)
Sun, 1 Aug 1999 13:33:20 -0600 (MDT)
I patched too soon. There's one other new warning, caused by a
function call to a prototyped function before the prototype is
seen. That cropped up in the date test. Here's a new patch to
fix both warnings in libwww-perl 5.44.
Nat
diff -ur libwww-perl-5.44-old/lib/LWP/Protocol.pm libwww-perl-5.44/lib/LWP/Protocol.pm
--- libwww-perl-5.44-old/lib/LWP/Protocol.pm Fri Jun 18 17:05:14 1999
+++ libwww-perl-5.44/lib/LWP/Protocol.pm Sun Aug 1 12:59:09 1999
@@ -114,7 +114,7 @@
$ic = "LWP::Protocol::nntp" if $scheme eq 'news'; #XXX ugly hack
no strict 'refs';
# check we actually have one for the scheme:
- unless (defined @{"${ic}::ISA"}) {
+ unless (@{"${ic}::ISA"}) {
# try to autoload it
eval "require $ic";
if ($@) {
diff -ur libwww-perl-5.44-old/lib/LWP/UserAgent.pm libwww-perl-5.44/lib/LWP/UserAgent.pm
--- libwww-perl-5.44-old/lib/LWP/UserAgent.pm Fri Jun 25 02:54:50 1999
+++ libwww-perl-5.44/lib/LWP/UserAgent.pm Sun Aug 1 12:58:31 1999
@@ -323,7 +323,7 @@
$class =~ s/-/_/g;
no strict 'refs';
- unless (defined %{"$class\::"}) {
+ unless (%{"$class\::"}) {
# try to load it
eval "require $class";
if ($@) {
Only in libwww-perl-5.44: makelog
diff -ur libwww-perl-5.44-old/t/base/date.t libwww-perl-5.44/t/base/date.t
--- libwww-perl-5.44-old/t/base/date.t Sat Jun 19 18:10:59 1999
+++ libwww-perl-5.44/t/base/date.t Sun Aug 1 13:23:47 1999
@@ -127,6 +127,11 @@
print "Testing AM/PM gruff...\n";
+# Test the str2iso routines
+use HTTP::Date qw(time2iso time2isoz);
+
+print "Testing time2iso functions\n";
+
$t = time2iso(str2time("11-12-96 0:00AM"));print "$t\n";
ok($t ne "1996-11-12 00:00:00");
@@ -153,11 +158,6 @@
ok($t ne "1996-11-12 12:05:00");
-
-# Test the str2iso routines
-use HTTP::Date qw(time2iso time2isoz);
-
-print "Testing time2iso functions\n";
$a = time2iso;
$b = time2iso(500000);