Re: [PATCH] libwww-perl5.00 MD5

• Messages sorted by: [ date ][ thread ][ subject ][ author ]
• Next message: Larry Schwimmer: "libwww bin install path wrong -- MakeMaker short-coming?"
• Previous message: Michael Morse: "Test error if you're not root"
• Maybe in reply to: Larry Schwimmer: "[PATCH] libwww-perl5.00 MD5"
• Next in thread: Andreas Koenig: "Re: [PATCH] libwww-perl5.00 MD5"

I'm not too familiar with this new module.  Is this MD5 with in a new
namespace or another module all together?  Is Crypt::MD5 fully compatible
with the existing MD5?  If so, I have a few comments below.  If not, you
certainly need to patch more.  

Regards,

-Doug

At 01:45 AM 5/30/96 -0700, Larry Schwimmer wrote:
>	libwww uses the old name for the MD5 module.
>	From the CHANGES file from MD5 1.6:
>
>*** 96/04/29 Version 1.6
>
>Changed modules name to Crypt::MD5
>
>	Patch follows.
>
>			yours,
>				Larry Schwimmer
>				schwim@cyclone.stanford.edu
>				Distributed Computing Operations
>
>--- lib/LWP/UserAgent.pm.orig	Sun May 19 04:09:04 1996
>+++ lib/LWP/UserAgent.pm	Thu May 30 01:43:14 1996
>@@ -340,7 +340,7 @@
> 		}
> 	    } elsif ($scheme =~ /^Digest$/i) {
> 		# http://hopf.math.nwu.edu/digestauth/draft.rfc
>-		require MD5;
>+		use Crypt::MD5;

Can we say 'require Crypt::MD5' here?  I had this originally so MD5 would
only be loaded if it was needed, which would be never for many people.

> 		my $md5 = new MD5;

Shouldn't that be 'new Crypt::MD5'?

> 		my($uid, $pwd) = $self->get_basic_credentials($realm,
> 							      $request->url);
>--- Makefile.PL.orig	Sun May 26 04:09:01 1996
>+++ Makefile.PL	Thu May 30 01:43:48 1996
>@@ -46,9 +46,9 @@
>     print " ok\n";
> }
> 
>-print "Checking for MD5 .......";
>+print "Checking for Crypt::MD5 .......";
> eval {
>-    require MD5;
>+    use Crypt::MD5;
> };
> if ($@) {
>     print " failed\n";
>
>

• Next message: Larry Schwimmer: "libwww bin install path wrong -- MakeMaker short-coming?"
• Previous message: Michael Morse: "Test error if you're not root"
• Maybe in reply to: Larry Schwimmer: "[PATCH] libwww-perl5.00 MD5"
• Next in thread: Andreas Koenig: "Re: [PATCH] libwww-perl5.00 MD5"